For a recent tour, I used a Miller front light and a Union tail light, both with LED bulb upgrades. They looked appropriate on the 1970 Mondia. I powered them with a Shimano dynohub. I built 650b wheels anyway, so installing the hub was no extra effort. Were I to do this again, I would install a capacitor circuit to smooth out the flashing at low speed caused by AC power going to diode bulbs. The Union tail light was not adequately secured, and the bracket fatigued and broke while banging along a gnarly singletrack in Idaho.
As to bottle generators, I had too many rattle loose BITD to ever trust them. While I never crashed from that, I saw some nasty wrecked bikes with collapsed forks or stays come into the shop I worked at.